Michael Eager wrote:
> I've noticed a problem with the patch:
> if test "${with_newlib+set}" = set; then
> AC_LIBTOOL_DLOPEN
> fi
>
> The test always succeeds. When $with_newlib is "yes",
> ${with_newlib+set} is "set".
>
> If I change this to the old style test
> if test "x$with_newlib" = x; then
> AC_LIBTOOL_DLOPEN
> fi
> then it works as expected.
>
> This is weird. I see the former idiom everywhere in configure.
> The tests can't all be failing.
I think both are wrong. You should be testing whether it equals the
value "yes", not whether or not the variable is set, because
$with_newlib can equally be blank or set to "no" in a non-newlib case.
Brian
