On 12/22/14 04:14, Eric Botcazou wrote:
Revised version after Joseph's comments and latest libgcc changes.
gcc/ChangeLog
2014-12-22 Eric Botcazou <ebotca...@adacore.com>
* config.gcc: Add Visium support.
* configure.ac: Likewise.
* configure: Regenerate.
* doc/extend.texi (interrupt attribute): Add Visium.
* doc/invoke.texi: Document Visium options.
* doc/install.texi: Document Visium target.
* doc/md.texi: Document Visium constraints.
* common/config/visium: New directory.
* config/visium: Likewise.
I don't see anything particularly offensive. Actually it looks like a
reasonably clean RISC port.
I'm a little concerned about the MODES_TIEABLE_P definition, but if it's
working, I wouldn't mess with it.
Any thoughts on using LRA for this port? Ideally we want to be moving
away from reload as much as we can.
I didn't look closely, do you need blockage insns in your epilogue/prologue?
For the prologue, if you store callee saved registers using the frame
pointer, then you need a blockage to ensure those stores don't bubble up
before the local stack gets allocated. And you need something analogous
in the epilogue. I didn't check your port carefully for this, but I'd
advise doing so.
Presumably you're going to be the maintainer for this port? If not you,
then who will maintain the port (so i can get maintainership officially
blessed by the SC).
I think this is good to go into the trunk. The blockage issue (if it's
an issue) can be resolved as a follow-up.
Jeff
