Hi Jakub! On Fri, 19 Dec 2014 11:36:39 +0100, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Dec 18, 2014 at 07:00:09PM +0100, Thomas Schwinge wrote: > > > The point is that we now have lots of clauses, and making it clear what > > > from > > > those clauses are Cilk+, what are OpenACC, what are OpenMP will help with > > > code readability. > > So here is what I'd like to see with PRAGMA_O*_CLAUSE_*, it matches what we > do already for Cilk+ and at least to me makes the code more readable.
Thanks for the patch! OK, so that's what you meant. So be it. :-) > gomp-4_0-branch compiles with it, haven't tested anything. Looks good, too. Are you going to commit your patch? > Note, it seems some of these OpenACC clauses are parsed only by C and not > C++, e.g. vector clause, but they aren't listed on any acc constructs > anyway. That's correct; the implementation is still not complete, also in C and Fortran. Grüße, Thomas
pgpGjrpvNvhuv.pgp
Description: PGP signature