On Thu, Dec 18, 2014 at 12:07:01PM +0100, Thomas Schwinge wrote:
> Many thanks for the review comments!  The very most have been addresed,
> here are just a few comments.  If you feel strongly/differently about
> any, I'll address those, too.

So, with your latest change both compilers build:
mkdir objmic; cd objmic
../configure --build=x86_64-intelmicemul-linux-gnu 
--host=x86_64-intelmicemul-linux-gnu --target=x86_64-intelmicemul-linux-gnu 
--enable-as-accelerator-for=x86_64-pc-linux-gnu --disable-bootstrap
make -j16
make DESTDIR=`pwd`/../objinst install
mkdir ../obj; cd ../obj
../configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu 
--target=x86_64-pc-linux-gnu 
--enable-offload-targets=x86_64-intelmicemul-linux-gnu=/usr/src/gomp-4.0/objmic 
--disable-bootstrap
make -j16

But there are issues during make check.
I first did:
make -j16 -k check RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} gomp.exp 
goacc.exp goacc-gomp.exp'
and that shows:
Making a new config file...
echo "set tmpdir /usr/src/gomp-4.0/obj/gcc/testsuite" >> ./site.tmp
rm -rf testsuite/gcc-parallel
rm -rf testsuite/g++-parallel
rm -rf testsuite/gfortran-parallel
rm -rf testsuite/objc-parallel
mkdir: cannot create directory ‘testsuite’: File exists
make[1]: Entering directory '/usr/src/gomp-4.0/obj/gcc'
make[1]: Entering directory '/usr/src/gomp-4.0/obj/gcc'
make[1]: Entering directory '/usr/src/gomp-4.0/obj/gcc'
make[1]: Entering directory '/usr/src/gomp-4.0/obj/gcc'
mkdir: cannot create directory ‘plugin’: File exists
mkdir: cannot create directory ‘plugin’mkdir: : File existscannot create 
directory ‘plugin’
: File exists
mkdir: cannot create directory ‘plugin’: File exists
Makefile:3787: recipe for target 'check-parallel-gcc_1' failed
make[1]: [check-parallel-gcc_1] Error 1 (ignored)
Makefile:3787: recipe for target 'check-parallel-gcc_2' failed
make[1]: [check-parallel-gcc_2] Error 1 (ignored)
Makefile:3787: recipe for target 'check-parallel-gcc_3' failed
make[1]: [check-parallel-gcc_3] Error 1 (ignored)
Makefile:3787: recipe for target 'check-parallel-gcc_4' failed
make[1]: [check-parallel-gcc_4] Error 1 (ignored)

Clearly preexisting problem even on trunk, so not a show stopper for this.

And in libgomp the testing fails completely:

Making check in testsuite
make[1]: Entering directory 
'/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
make  check-DEJAGNU
make[2]: Entering directory 
'/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
Making a new site.exp file...
srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd ../../../../libgomp/testsuite && pwd`; 
export srcdir; \
EXPECT=expect; export EXPECT; \
runtest="runtest "; \
if /bin/sh -c "$runtest --version" > /dev/null 2>&1; then \
  exit_status=0; l='libgomp'; for tool in $l; do \
    if $runtest  --tool $tool --srcdir $srcdir ; \
    then :; else exit_status=1; fi; \
  done; \
else echo "WARNING: could not find \`runtest'" 1>&2; :;\
fi; \
exit $exit_status
WARNING: Couldn't find the global config file.
ERROR: tcl error sourcing libgomp-test-support.exp.
can't read "(target_alias)": no such variable
    while executing
"set offload_additional_options " 
-B/usr/src/gomp-4.0/objmic/libexec/gcc/$(target_alias)/$(gcc_version) 
-B/usr/src/gomp-4.0/objmic/bin""
    (file "libgomp-test-support.exp" line 5)
    invoked from within
"source libgomp-test-support.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source libgomp-test-support.exp"
    invoked from within
"catch "uplevel #0 source $file""
Makefile:277: recipe for target 'check-DEJAGNU' failed
make[2]: *** [check-DEJAGNU] Error 1
make[2]: Leaving directory 
'/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
Makefile:314: recipe for target 'check-am' failed
make[1]: *** [check-am] Error 2
make[1]: Leaving directory 
'/usr/src/gomp-4.0/obj/x86_64-pc-linux-gnu/libgomp/testsuite'
Makefile:856: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1

So clearly the *.exp files need to be taught where to look for 
libgomp-test-support.exp.

        Jakub

Reply via email to