On Wed, 2014-11-19 at 23:09 -0800, Mike Stump wrote: > On Nov 19, 2014, at 10:23 PM, David Malcolm <dmalc...@redhat.com> > wrote: > > It's not clear to me if I can approve my own patches to the jit > > So, to answer that, we look at MAINTAINERS, and look up your name: > > Various Maintainers > > jit David Malcolm <dmalc...@redhat.com> > > So, this means that you can review other peoples work and approve it > for the jit code, and you can review and approve your own work for the > jit code. This is the definition of Maintainer. If you had been > listed under Reviewers, you would need approval for your own work. > > Now, that doesn’t mean, you can’t ask for a review for any reason you > want. :-)
[CCing Jeff] Indeed, but Jeff wrote in another thread: > JIT space, yours to approve :-) We haven't formalized that > yet, but it'd be silly to do anything else. [ https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02514.html ] ...and that got me wondering if: (A) there's an additional governance step here that should happen, or (B) if I can go ahead and commit suitably tested patches that are confined to the: gcc/jit gcc/testsuite/jit.exp subdirectories (and approve other people's such patches), or (C) both i.e. do (B) whilst (A) is pending Thanks Dave
