On Wed, Nov 19, 2014 at 04:41:49PM +0100, Marek Polacek wrote: > > - HOST_WIDE_INT c, lsb; > > + unsigned HOST_WIDE_INT c, lsb; > > > > c = INTVAL (op); > > Shouldn't you use UINTVAL then?
That doesn't really matter here. It looks a bit cleaner, of course. I wouldn't spend too much time on mask*operand, I'll replace them wholesale if all plans fall in place... Segher
