Hi,

On Fri, Nov 14, 2014 at 04:23:41PM +0100, Martin Liska wrote:
> Patch v3.
> 
> Martin

> From 7255ffaf7bb416037baa14499b197bac3be8c222 Mon Sep 17 00:00:00 2001
> From: mliska <mli...@suse.cz>
> Date: Fri, 14 Nov 2014 16:14:28 +0100
> Subject: [PATCH 2/3] First usage of cgraph_summary in ipa-prop pass.
> 
> gcc/ChangeLog:
> 
> 2014-11-12  Martin Liska  <mli...@suse.cz>
> 
>       * ipa-prop.c (struct func_body_info): Struct keyword is removed.
>       (struct ipa_cst_ref_desc): Likewise.
>       (ipa_func_spec_opts_forbid_analysis_p): Likewise.
>       (ipa_alloc_node_params): Likewise.
>       (ipa_initialize_node_params): Likewise.
>       (ipa_print_node_jump_functions_for_edge): Likewise.
>       (ipa_print_node_jump_functions): Likewise.
>       (ipa_print_all_jump_functions): Likewise.
>       (ipa_set_jf_constant): Likewise.
>       (check_stmt_for_type_change): Likewise.
>       (detect_type_change_from_memory_writes): Likewise.
>       (find_dominating_aa_status): Likewise.
>       (parm_bb_aa_status_for_bb): Likewise.
>       (parm_preserved_before_stmt_p): Likewise.
>       (parm_ref_data_preserved_p): Likewise.
>       (parm_ref_data_pass_through_p): Likewise.
>       (struct ipa_known_agg_contents_list): Likewise.
>       (get_place_in_agg_contents_list): Likewise.
>       (build_agg_jump_func_from_list): Likewise.
>       (determine_locally_known_aggregate_parts): Likewise.
>       (ipa_compute_jump_functions_for_edge): Likewise.
>       (ipa_compute_jump_functions_for_bb): Likewise.
>       (ipa_note_param_call): Likewise.
>       (ipa_analyze_indirect_call_uses) Likewise.:
>       (ipa_analyze_virtual_call_uses): Likewise.
>       (ipa_analyze_call_uses): Likewise.
>       (visit_ref_for_mod_analysis): Likewise.
>       (ipa_analyze_controlled_uses): Likewise.
>       (ipa_analyze_node): Likewise.
>       (update_jump_functions_after_inlining): Likewise.
>       (ipa_make_edge_direct_to_target): Likewise.
>       (ipa_find_agg_cst_for_param): Likewise.
>       (remove_described_reference): Likewise.
>       (jfunc_rdesc_usable): Likewise.
>       (try_decrement_rdesc_refcount): Likewise.
>       (try_make_edge_direct_simple_call): Likewise.
>       (try_make_edge_direct_virtual_call): Likewise.
>       (update_indirect_edges_after_inlining): Likewise.
>       (propagate_info_to_inlined_callees): Likewise.
>       (propagate_controlled_uses): Likewise.
>       (ipa_propagate_indirect_call_infos): Likewise.
>       (ipa_free_all_edge_args): Likewise.
>       (ipa_node_params::~ipa_node_params): Likewise.
>       (ipa_free_all_node_params): Likewise.
>       (ipa_edge_removal_hook): Likewise.
>       (ipa_node_removal_hook): Likewise.
>       (ipa_edge_duplication_hook): Likewise.
>       (ipa_add_new_function): Removed
>       (ipa_node_params_t::duplicate): New function.
>       (ipa_node_duplication_hook): Struct keyword removed.
>       (ipa_register_cgraph_hooks): Removal of old hooks.
>       (ipa_unregister_cgraph_hooks): Likewise.
>       (ipa_print_node_params): Struct keyword is removed.
>       (ipa_print_all_params): Likewise.
>       (ipa_modify_formal_parameters): Likewise.
>       (ipa_modify_call_arguments): Likewise.
>       (ipa_modify_expr): Likewise.
>       (ipa_get_adjustment_candidate): Likewise.
>       (index_in_adjustments_multiple_times_p): Likewise.
>       (ipa_combine_adjustments): Likewise.
>       (ipa_dump_param_adjustments): Likewise.
>       (ipa_write_jump_function): Likewise.
>       (ipa_read_jump_function): Likewise.
>       (ipa_write_indirect_edge_info): Likewise.
>       (ipa_read_indirect_edge_info): Likewise.
>       (ipa_write_node_info): Likewise.
>       (ipa_read_node_info): Likewise.
>       (ipa_prop_write_jump_functions): Likewise.
>       (ipa_prop_read_section): Likewise.
>       (ipa_prop_read_jump_functions): Likewise.
>       (write_agg_replacement_chain): Likewise.
>       (read_agg_replacement_chain): Likewise.
>       (ipa_prop_write_all_agg_replacement): Likewise.
>       (read_replacements_section): Likewise.
>       (ipa_prop_read_all_agg_replacement): Likewise.
>       (adjust_agg_replacement_values): Likewise.
>       (ipcp_modif_dom_walker::before_dom_children): Likewise.
>       (ipcp_transform_function): Likewise.

If you don't have to, please don't.  If you make a change somewhere
for some particular reason, by all means remove all struct keywords on
that line or in its vicinity, that is what I try to do as well.  But
this will just make it much more difficult to revive some older
patches of mine for no good reason. It also makes looking up and
reviewing the functional changes in this patch very slow and
demanding.

Martin

Reply via email to