On 06 Nov 19:21, Jakub Jelinek wrote: > I'm still seeing various unhandled malloc failures, e.g.: > ... > would crash if malloc returns NULL. Similarly for realloc:
Fixed in the branch: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=534b201fadf0af05ca509dc3f8e13ef26ee719a2 > Also, I see you heavily use malloc.h, not sure how portable that is, > certainly e.g. gcc checks through configure for its presence. I suppose > stdlib.h being more portable. Or, if you want liboffloadmic to be supported > only on i?86-*-linux* / x86_64-*-linux* rather than all i?86/x86_64 targets, > maybe you should say so in configure.tgt. If you leave it on for all > i?86/x86_64 targets, be prepared to handle issues on Darwin, mingw/cygwin, > BSDs etc. So far we have tested only i686/x86_64 linux, but probably we will support other systems in the future. I restricted $target to x86_64-*-linux* and i?86-*-linux* in configure.tgt. On 12 Nov 11:40, Jakub Jelinek wrote: > So, the whole series is ok to check in now. Thanks. Great, thank you! We're going to check in all patches today after additional regtesting. -- Ilya
