On Nov 10, 2014, at 6:58 AM, FX <fxcoud...@gmail.com> wrote: >> My knowledge of C++ is limited, but I think this additional patch to >> wide-int.h is the proper fix to the issue reported by Jack, no? >> I’m bootstrapping it right now, it already passed stage 2. > > Boostrapped succeeded on x86_64-apple-darwin14. > OK to commit to trunk?
I’m ok with this version. I’’ve asked Jack for the header in question that makes max/min ambiguous. I think this is a bug in the system libraries, that said, I’m ok with working around the bug in the wide-int source code as expedient. I think including string in system.h is unfortunate, and I think the whole do_not_use_toupper_with_safe_ctype thing is unfortunate. Unless someone wants to reengineer ctype… or require the removal of string and all other system headers that are not in system.h… I think this is as good as we can do for now.
