On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote: > I committed the change to go-test.exp. Thanks. > > The other changes are not OK. As described in > gcc/testsuite/go.test/test/README.gcc, the files in > gcc/testsuite/go.test/test are an exact copy of the master Go > testsuite. Any changes must be made to the master Go testsuite first.
I understand that, but I'm unsure how to handle a set of patches that all depend on each other but refer to three different reposiories. So I posted this patch intentionally in the wrong place, not knowing how to do it in a better way. > I don't know what's up with the complex number change. In general the > Go compiler and libraries go to some effort to produce the same > answers on all platforms. We need to understand why we get different > answers on s390 (you may understand the differences, but I don't). I > won't change the tests without a clear understanding of why we are > changing them. It's actually not a Go specific problem, the same deviation occurs in C code too. The cause is that constant folding is done with a higher precision and may yield a different result than the run time calculations. There is a Gcc bug report for that "issue": https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60181 > The nilptr test doesn't run on some other platforms when using > gccgo--search for "nilptr" in go-test.exp. If you want to work out a > way to change the master Go testsuite such that the nilptr test passes > on more platforms, that would be great. I don't have the slightest clue how this could be done in a platform independent way because the test heavily depends on the target's memory map layout. > The way to do it is not by > copying the test. If the test needs to be customized, add additional > files that use // +build lines to pick which files is built. Move > them into a directory, like method4.go or other tests that use > "rundir". I'll check that. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany
