On 28/10/14 12:34, Jakub Jelinek wrote: > On Tue, Oct 28, 2014 at 12:24:39PM +0000, Phil Muldoon wrote: >> 2014-10-28 Phil Muldoon <pmuld...@redhat.com> >> >> * configure.ac: Remove -Werror. >> * configure: Regenerate. >> * Makefile.am: Remove -Werror. Link correct libiberty. >> * Makefile.in: Regenerate. > > As for -Werror, doesn't your patch completely remove -Werror from the flags? > Looking around, we have config/warnings.m4 which contains > ACX_PROG_CC_WARNINGS_ARE_ERRORS([manual]) > macro used by several libraries, which supposedly enables -Werror when > requested. > > Jakub
Yeah Uros was reporting that the -Werror flag in configure.ac was also conflicting. auto-* tools are definetly not my strong point, and I did not write these build configurations. Anyway, this is somewhat moot as your patch is earlier and better than mine, so we'll go with that. Thanks for taking a look at the issue and coming up with a fix. Cheers Phil
