> From: Christophe Lyon [mailto:christophe.l...@linaro.org] > Sent: Sunday, October 26, 2014 4:40 PM > I tried to modify check_effective_target_bswap > and added: > + } else { > + if { [istarget arm*-*-*] > + && [check_no_compiler_messages_nocache arm_v6_or_later > object { > + #if __ARM_ARCH < 6 > + #error not armv6 or later > + #endif > + int i; > + } ""] } { > + set et_bswap_saved 1 > + } > since the rev* instructions appeared in v6. > > Regarding the testsuite, it moves the tests to UNSUPPORTED vs a mix of > PASS/FAIL/XFAIL
[SNIP PASS/FAIL/XFAIL changes] > > The PASS seems not very informative, so it may not be a problem to > loose these few PASS/XFAIL. Agreed. A FAIL would only mean that the test was badly written. Only the dump is relevant to tell whether the bswap pass did its job or not. > > We can also explicitly skip optimize-bswaphi-1 when ARM_ARCH < 6. > > Not sure what's preferred? I prefer changing the effective target as it could be reused for some other tests eventually. It also reflects better the reason why the test is disabled: no 16-bit bswap. Best regards, Thomas
