On 24 Oct 18:07, Jakub Jelinek wrote: > On Fri, Oct 24, 2014 at 08:03:42PM +0400, Ilya Verbin wrote: > > A small addition, refcount and copy_from were uninitialized for globals. > > > > > > diff --git a/libgomp/target.c b/libgomp/target.c > > index 4ace170..5b4873b 100644 > > --- a/libgomp/target.c > > +++ b/libgomp/target.c > > @@ -647,6 +647,8 @@ gomp_init_device (struct gomp_device_descr *devicep) > > k->host_start = table[i].host_start; > > k->host_end = table[i].host_end; > > k->tgt_offset = 0; > > + k->refcount = 1; > > + k->copy_from = false; > > k->tgt = tgt; > > node->left = NULL; > > node->right = NULL; > > Is that what Kirill reported today on IRC? LGTM.
Right. -- Ilya
