On Wed, Oct 22, 2014 at 11:02 AM, Jiong Wang <jiong.w...@arm.com> wrote: > > On 21/10/14 15:30, Ramana Radhakrishnan wrote: >> >> On Mon, Oct 13, 2014 at 3:15 PM, Renlin Li <renlin...@arm.com> wrote: >>> >>> Hi all, >>> >>> This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined >>> marco(ACLE 2.0) into TARGET_CPU_CPP_BUILTINS. >>> Is it Okay to commit? >>> >>> >>> gcc/ChangeLog: >>> >>> 2014-10-13 Renlin Li <renlin...@arm.com> >>> >>> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add ACLE 2.0 >>> predefined >>> marco __ARM_FEATURE_IDIV__. >> >> Replace this with "Define __ARM_FEATURE_IDIV__." in the Changelog.
Are you sure that the ACLE documents this with trailing underscores ? The copy that I have doesn't. Ramana >> >> Ok with that change. > > > committed on behalf of Renlin as 216547. > > 2014-10-22 Renlin Li <renlin...@arm.com> > gcc/ > * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Define > __ARM_FEATURE_IDIV__. > > Also fixed the missing '\' on the last line as obvious > > 2014-10-22 Jiong Wang <jiong.w...@arm.com> > > gcc/ > * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add missing '\'. > > > Index: gcc/config/arm/arm.h > =================================================================== > --- gcc/config/arm/arm.h (revision 216547) > +++ gcc/config/arm/arm.h (working copy) > @@ -167,7 +167,7 @@ > { \ > builtin_define ("__ARM_ARCH_EXT_IDIV__"); \ > builtin_define ("__ARM_FEATURE_IDIV__"); \ > - } > + } \ > } while (0) > #include "config/arm/arm-opts.h" > >> >> Ramana >> > >