On Tue, 21 Oct 2014, Ilya Verbin wrote:
> +#include <libgen.h>
> +#include "config.h"
> +#include "system.h"
You should never include system headers before config.h because config.h
may define feature test macros such as _FILE_OFFSET_BITS=64 that are
ineffective if defined after any system header is included.
I don't see anything restricting this program to being built for GNU
*hosts*. Thus, it needs to be portable (to different hosts; obviously
it's target-architecture-specific) rather than relying on glibc
interfaces. (Providing appropriate functions in libiberty is of course an
option; thus, freely using obstacks is fine because they're in libiberty.)
> +#include <libgomp_target.h>
Where does this header come from?
> + nextval = strchrnul (curval, ':');
I don't think strchrnul is portable (unless added to libiberty).
> + if (!host_compiler)
> + fatal_error ("COLLECT_GCC must be set.");
Diagnostics should not end with ".".
--
Joseph S. Myers
jos...@codesourcery.com
