On Thu, Oct 16, 2014 at 10:24:45AM +0400, Kirill Yukhin wrote:
> Hello,
> This patch extends insertion hook.
>
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
>
> gcc/
> * config/i386/i386.c
> (ix86_expand_vector_set): Handle V8DF, V8DI, V16SF, V16SI, V32HI, V64QI
> modes.
Just a ChangeLog comment style (seen in several entries you've committed
and several posted patches). Please don't put a line break right after
the filename if the (functionname): part fits nicely on the same line, the
description can be wrapped anywhere as appropriate.
In this case,
* config/i386/i386.c (ix86_expand_vector_set): Handle V8DF, V8DI,
V16SF, V16SI, V32HI, V64QI modes.
is shorter and more readable.
Other than that, this particular patch LGTM (unless we'd want for the 4
mostly repetitious cases add a common handling spot, which would need the
gen fnpointer and kmode vars set before goto), but I'll leave it to Uros to
ack it.
Jakub
