On Fri, Oct 10, 2014 at 8:03 PM, Jeff Law <l...@redhat.com> wrote: > On 10/10/14 01:42, Evgeny Stupachenko wrote: >> >> Hi, >> >> The patch enables EBX in RA for x86 32bits PIC mode. >> It was discussed here: >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02513.html >> Now there is working version with good performance and stability level >> - it could be a solid first step of EBX enabling. >> >> Bootstrap and make check passed. >> There are several changes in "-m32" make check. >> >> New pass: >> gcc.target/i386/pr57003.c - before patch there was not enough registers to >> PASS > > ?!? That doesn't make a lot of sense. More likely it was Uros's fix from > yesterday to regcprop which causes this to pass again. Correct. I've marked it by mistake. The test is flaky and the patch does not change anything for the test. > > Is it possible you updated your sources between testing runs and as a result > picked up Uros's fix? > >> >> New fails: >> >> gcc.target/i386/pic-1.c (test for errors, line 12) - now there are no >> errors as we can do asm insertions with EBX > > I think you should remove the dg-error directive. That turns this test into > a simple confirmation that we can use %ebx in an asm even when generating > PIC code. > > Can you add a PR markers to your changelog > > PR target/8340 > PR middle-end/47602 > PR rtl-optimization/55458 > > Actually I think there is an additional test in 47602. Can you please add > it to the suite? You'll also want to change the state of 47602 to > RESOLVED/FIXED. > > > > > > > >> gcc.target/i386/pr23098.c scan-assembler-not .LC[0-9] - potential >> performance opportunity using constant immediate > > If you're not going to fix it, then you should xfail it. > >> gcc.target/i386/pr55458.c (test for errors, line 10) - now there are >> no errors as there enough registers > > Right. Remove the dg-error and turn this into a test that effective > verifies that %ebx is no longer fixed when generating PIC code on i686. > > With those changes this is OK for the trunk. > > jeff > >
ChangeLog for testsuite:
2014-10-13 Evgeny Stupachenko <evstu...@gmail.com>
PR target/8340
PR middle-end/47602
PR rtl-optimization/55458
* gcc.target/i386/pic-1.c: Remove dg-error as test should pass now.
* gcc.target/i386/pr55458.c: Likewise.
* gcc.target/i386/pr47602.c: New.
* gcc.target/i386/pr23098.c: Move to XFAIL.
enabling_ebx_tests.patch
Description: Binary data
