On 10/10/14 02:17, Zhenqiang Chen wrote:
-----Original Message-----
From: Richard Biener [mailto:richard.guent...@gmail.com]
Sent: Thursday, October 09, 2014 5:21 PM
To: Zhenqiang Chen
Cc: GCC Patches
Subject: Re: [PATCH] Clean up duplicated function seq_cost
On Thu, Oct 9, 2014 at 11:20 AM, Richard Biener
<richard.guent...@gmail.com> wrote:
On Thu, Oct 9, 2014 at 11:14 AM, Zhenqiang Chen
<zhenqiang.c...@arm.com> wrote:
Hi,
The are two implementations of seq_cost. The function bodies are
exactly the same. The patch removes one of them and make the other
global.
Bootstrap and no make check regression on X86-64.
OK for trunk?
The prototype should go to cfgloopanal.c.
Err - cfgloopanal.h of course ;) Or rather the function sounds misplaced in
cfgloopanal.c.
Thanks for the comments. I think seq_cost should be in rtlanal.c, just like
rtx_cost, insn_rtx_cost and so on.
ChangeLog:
2014-10-10 Zhenqiang Chen <zhenqiang.c...@arm.com>
* cfgloopanal.c (seq_cost): Delete.
* rtl.h (seq_cost): New prototype.
* rtlanal.c (seq_cost): New function.
* tree-ssa-loop-ivopts.c (seq_cost): Delete.
Ok.
Jeff
