On Fri, Oct 10, 2014 at 07:47:19PM +0400, Ilya Tocar wrote:
> Updated patch below.

You haven't posted ChangeLog entry this time, so using the last one:

        * config/i386/i386.c                                                    
                                                                   
        (MAX_VECT_LEN): Move above ix86_expand_vec_perm_vpermi2.                
                                                                   
...
        * config/i386/sse.md                                                    
                                                                   
        (define_mode_iterator VI1_AVX512): New.                                 
                                                                   
I'd think you should avoid the line break after filename in these
cases, so
        * config/i386/i386.c (MAX_VECT_LEN): Move above
        ix86_expand_vec_perm_vpermi2.
...
        * config/i386/sse.md (define_mode_iterator VI1_AVX512): New.

Other than that nit it looks good to me.

        Jakub

Reply via email to