On 8 October 2014 11:10, Maxim Ostapenko
<m.ostape...@partner.samsung.com> wrote:
> Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish?
>
> I see two opportunities to fix the issue:
>
> 1) Implement a stack of saved contexts.
>
> 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path,
> to be able {asan, ubsan, tsan}_finish functions restore context correctly.
>
> What solution is preferable?

Option 1 has the advantage that it places all of the context save and
restore in one place rather than spreading it around the
infrastructure.

Please can we revert this patch while a correct implementation is being worked?

Cheers
/Marcus

Reply via email to