FX wrote: > Now, here's a tiny patch to silence the related warning in PR36534. > I also remove the condition on gfc_current_form != FORM_FIXED, as diagnostics > should be emitted based on language/pedantic options, not source form.
Looks good to me. However: In the test case, could you also add a "PR fortran/36534" to the as comment? Additionally, I wonder whether instead of the name-based checking + && (sym->name[0] != '_' || sym->name[1] != '_')) it wouldn't be cleaner to check && sym->attr.intrinsic (If you change it to attr.intrinsic, you need to set the attribute also in intrinsic.c's gfc_convert_type_warn.) I know that using __... names it not really possible in Fortran (except as C binding name), but - still - I think it is cleaner. But I am fine with either version. Tobias