On 09/19/14 06:21, Segher Boessenkool wrote:
On Thu, Sep 18, 2014 at 11:54:46PM -0600, Jeff Law wrote:
Shouldn't you be testing if the register is fixed rather than its class?
Or maybe both?
register_operand (via general_operand) uses operand_reg_set for this; it is
initialised via the regclass NO_REGS too (and other things).
This would work for us (rs6000) too, or indeed fixed_regs[], or even wider
classes. I have no idea if it would hurt other targets though, and I have
no desire to test all weirdo targets ;-)
Can't blame you for that :-)
Thanks for the pointer to operand_reg_set. Having walked through some
of that code, I think we're OK just looking at the class like your
original patch did.
Concerns withdrawn. Patch approved.
Jeff
