Trevor Saunders <tsaund...@mozilla.com> writes: > I also do think the advantages of using members outways the cost. > > For one thing functions with all caps names are just weird. I think the > more important reason though is that it will help make rtx_insn be a > separate class sometime in the far future, since at some point we can > make its inheritance from rtx_def protected to chase down things that > try to convert from rtx_insn to rtx. There's also the argument that its > inconsistant to have some things be members and others be functions.
+1 FWIW. I think after conversion all rtx fields should be accessed using the same style, rather than a mixture of caps-functions for some fields and member functions for others. Thanks, Richard