On Wed, 3 Sep 2014, Uros Bizjak wrote: > > So I think the default timeout that's used for really quick tests should > > be extended a bit. I propose a factor of 2, just not to make it too > > excessive, at least for the beginning (maybe it'll have to be higher > > eventually). > > Or you can just lower the iteration count as I have to do for alpha.
Thanks for the tip. Hmm, frankly I think setting the timeout factor has a greater chance to be maintenance free (no need to add further targets as they get discovered) and I think a bit more flexible too. E.g. someone may (and often will, if they care about their test run times) override the global board timeout to say 5 from the default of 300 seconds in their board description file for their super-fast test system and the timeout factor will still do its work here. Whereas with the default timeout applying here the lowest timeout setting that works here will be the global lower limit, also for tests that are inherently faster than this one (i.e. don't loop over thousands of iterations or in fact have no loop at all and just execute in a fall-through manner) even on systems where lock contention is not an issue. If you think that extending the timeout for everyone is too big a hammer here, then perhaps we could conditionalise it on target_has_contentious_atomics or suchlike and list the right targets there, but frankly I think it would be a bit of an overkill (and my observation above about looped vs non-looped tests still applies). Thoughts? Maciej
