On Sep 4, 2014, at 4:14 AM, Ramana Radhakrishnan <ramana....@googlemail.com>
wrote:
>> --- a/gcc/testsuite/lib/target-supports.exp
>> +++ b/gcc/testsuite/lib/target-supports.exp
>> @@ -2293,8 +2293,8 @@ proc check_effective_target_arm_little_endian { } {
>> proc check_effective_target_arm_vect_no_misalign { } {
>> return [check_no_compiler_messages arm_vect_no_misalign assembly {
>> #if !defined(__arm__) \
>> - || (defined(__ARMEL__) \
>> - && (!defined(__thumb__) || defined(__thumb2__)))
>> + || (defined(__ARM_FEATURE_UNALIGNED) \
>> + && defined(__ARMEL__))
>> #error FOO
>> #endif
>> }]
>>
>
> Ok by me. But please wait for a testsuite maintainer to approve.
Ok.
Generally the port people that have been around for a while know what strikes
them as wrong or not and can just approve the patch directly. I suspect you
are one of those people. :-) If you have any doubts or concerns, you can
always raise them or ask for some help reviewing. Don’t worry, if I spot
something I don’t like after someone else says Ok, I will bring up the issue
for consideration. Even if I do, it doesn’t mean I object in anyway to the
first review.
