On Wed, Aug 27, 2014 at 4:42 AM, Aldy Hernandez <al...@redhat.com> wrote: > This patch fixes a bunch of guality failures. With it I get 144 guality.exp > failures vs. 163 for "make check-gcc RUNTESTFLAGS=guality.exp". A lot > better than 100% fail rate ;-). > > Variable DIEs were not being reused. Instead, variable DIEs even had the > wrong context (unilaterally the compilation unit). The attached patch > reuses variable DIEs that have been outputted earlier. It also fixes the > context by correcting the context on the second round. > > I have also added a bit field to the DIE structure to record if a DIE has > been generated early. > > Again, this is all a rough draft, but feel free to comment.
I wonder if we can't not force a proper context die (ISTR dwarf2out.c lazily handles some contexts in some circumstances). All parent "trees" should be readily available and we should be able to create DIEs for them. Richard. > Committed to branch. > Aldy
