On Wed, Aug 20, 2014 at 4:45 PM, Evandro Menezes <e.mene...@samsung.com> wrote:
> This is a trivial patch.  However, without it, the addressing mode cost is
> incorrectly calculated, since the cost intended for HI end up being used for
> SI on A57.

Pinging patches every day isn't going to help :). Pinging weekly is
the generally accepted norm in this community.
https://gcc.gnu.org/contribute.html#patches even says this is 2 weeks
!  I cannot approve this patch even though it looks sane to me.

Folks who are listed as maintainers are real people and are allowed a
life outside GCC, you know ... :)

regards
Ramana

>
> I'd appreciate your considering this patch fixing this issue.
>
> Thank you,
>
> --
> Evandro Menezes                             Austin, USA
> e.mene...@samsung.com                   +1-512-425-3365
>
>
> -----Original Message-----
> From: Evandro Menezes [mailto:e.mene...@samsung.com]
> Sent: Tuesday, August 19, 2014 14:40
> To: 'James Greenhalgh'
> Cc: 'gcc-patches@gcc.gnu.org'; 'James Greenhalgh';
> 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com'
> Subject: RE: [PATCH, AArch64] Fix typo
>
> Ping, pretty please.
>
> --
> Evandro Menezes                             Austin, USA
> e.mene...@samsung.com                   +1-512-425-3365
>
> -----Original Message-----
> From: Evandro Menezes [mailto:e.mene...@samsung.com]
> Sent: Monday, August 18, 2014 10:02
> To: 'James Greenhalgh'
> Cc: 'gcc-patches@gcc.gnu.org'; 'James Greenhalgh';
> 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com'
> Subject: RE: [PATCH, AArch64] Fix typo
>
> Ping.
>
> --
> Evandro Menezes                             Austin, USA
> e.mene...@samsung.com                   +1-512-425-3365
> -----Original Message-----
> From: Evandro Menezes [mailto:e.mene...@samsung.com]
> Sent: Friday, August 15, 2014 14:55
> To: 'James Greenhalgh'
> Cc: 'gcc-patches@gcc.gnu.org'; 'James Greenhalgh';
> 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com'
> Subject: RE: [PATCH, AArch64] Fix typo
>
> Thanks for the review.
>
> --
> Evandro Menezes                             Austin, USA
> e.mene...@samsung.com                   +1-512-425-3365
>
> -----Original Message-----
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org]
> On Behalf Of James Greenhalgh
> Sent: Friday, August 15, 2014 11:36
> To: Evandro Menezes
> Cc: gcc-patches@gcc.gnu.org; 'James Greenhalgh'; richard.earns...@arm.com;
> marcus.shawcr...@arm.com
> Subject: Re: [PATCH, AArch64] Fix typo
>
> On Fri, Aug 15, 2014 at 05:24:58PM +0100, Evandro Menezes wrote:
>> I tripped at a typo that goes undetected because the macro NAMED_PARAM
>> doesn't apply in the absence of designated initializers.
>>
>> Since struct scale_addr_mode_cost has the cost for DI, but not for QI,
>> the instances of struct cpu_addrcost_table are not initialized as
>> intended due to the different order of the structure members.
>
> Thanks for spotting and fixing this.
>
> The ChangeLog entry should be added to gcc/ChangeLog, and should look like
> this:
>
> 2014-08-14  Evandro Menezes  <e.mene...@samsung.com>
>
>         * config/aarch64/aarch64.c (generic_addrcost_table): Initialize
>         elements in the correct order.
>         (cortexa57_addrcost_table): Likewise.
>
> My fixes were:
>   * Two spaces between your name and email address.
>   * Name the structure/function/thing changed.
>   * Set the path relative to the ChangeLog being modified.
>
> Otherwise, this patch looks correct to me. However, you will need approval
> from an AArch64 port maintainer (For AArch64 this is Richard Earnshaw or
> Marcus Shawcroft - both added to CC).
>
> Thanks,
> James

Reply via email to