On 08/19/2014 12:41 PM, Ilya Verbin wrote:
On 18 Aug 18:24, Bernd Schmidt wrote:
I think I'd be happier if the function was called init_offload_table
and also collected functions, rather than leaving that to
expand_omp_target. I think the patch would be ok with that change.
For the functions it's not so easy to identify which of them to add into the
table, e.g.:
#pragma omp target
#pragma omp parallel
x++;
Here 2 functions with "omp declare target" attribute are created. But only the
outer must be added to the table.
So I believe that expand_omp_target is better place for the functions.
Hmm, ok. Can you elaborate how this happens and why only one must be
added to the table?
In any case, I think let's get this checked in for now and iterate later.
Bernd
