On 8 August 2014 02:30, Janis Johnson <janis_john...@mentor.com> wrote: > Running an arm-none-eabi test that adds "-mthumb" for a multilib that > uses "-march=armv5te -mfloat-abi=hard" works fine if the test doesn't > have any calls, but if it does then the effective-target checks for > arm_thumb1_ok and arm_thumb2_ok pass but the test's compile step fails > with "sorry, unimplemented: Thumb-1 hard-float VFP ABI". > > This patch adds code to those effective-target checks to exercise > argument handling and causes them to fail for the multilib flags > listed above. Tested by running gcc.target/arm tests with a variety > of multilib flags. OK for mainline and the 4.9 branch? > > Janis
Some time ago (https://gcc.gnu.org/ml/gcc-patches/2012-09/msg01501.html) I suggested to add similar stuff to check_effective_target_arm_arch_FUNC_ok for similar reasons. Do you agree?