On 13/08/14 08:49, Thomas Preud'homme wrote: >> From: Richard Earnshaw >> Sent: Monday, August 11, 2014 4:54 PM >> >> I think this is the wrong place for this sort of fix up. HFmode values >> are fixed up in the consttable_4 pattern and it looks wrong to be that >> HImode values are then fixed up in a different place. We should be >> consistent and do all the fix ups in one location. > > Sorry for the delay in answering. > > The problem is that in the pattern for constable_4 we don't have the > information > about the access mode for this entry. In the testcase along this patch the rtx > manipulated in the pattern is VOIDmode while the access mode is HImode. In > dump_minipool on the other hand the information can be found in mp->mode. >
I think it would be better to make sure the mode field never contains VOIDmode. That's not really useful information. R.
