Thank you.

$ svn commit
Sending        gcc/ChangeLog
Sending        gcc/config/arm/thumb1.md
Sending        gcc/config/arm/thumb2.md
Transmitting file data ...
Committed revision 213695.

P.S.

Minor nit was reg. tested.

On 08/06/2014 06:44 PM, Richard Earnshaw wrote:
On 06/08/14 15:14, Ramana Radhakrishnan wrote:

This is OK thanks.


Ramana


Hmm, minor nit.

  (define_insn "*thumb1_movhi_insn"
    [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
-       (match_operand:HI 1 "general_operand"       "l,m,l,*h,*r,I"))]
+       (match_operand:HI 1 "general_operand"       "lk,m,l,*h,*r,I"))]

This would be better expressed as:

    [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
         (match_operand:HI 1 "general_operand"      "l,m,l,k*h,*r,I"))]

that is, to use the 4th alternative.  That's because the use of SP in
these operations does not clobber the flags.

Similarly for the movqi pattern.

R.



Reply via email to