On Tue, Aug 5, 2014 at 5:26 PM, Bruce Korb <bk...@gnu.org> wrote: > Hi, > > Lines 42 & 43 are not needed for fixincludes, but it is your choice. > With that change, you should not need to add that test to fixincludes > because __gnuc_va_list will be found within the comment and satisfy > the "bypass" expression.
okay, i'll reword to explicitly say that it's the reference to __gnuc_va_list that gets us the fixincludes behavior we want (which should also ensure that no one "cleans up" the reference to, say, __builtin_va_list). > That was the long way of saying: > Looks good to me. > > On Tue, Aug 5, 2014 at 5:09 PM, enh <e...@google.com> wrote: >> does https://android-review.googlesource.com/103445 look okay? >> >> On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb <bk...@gnu.org> wrote: >>> Hi, >>> >>> On Tue, Aug 5, 2014 at 10:36 AM, enh <e...@google.com> wrote: >>>> you can see the current version of bionic's stdio.h here: >>>> >>>> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h >>>> >>>> i'm happy to add any string to the header file that makes things >>>> easier. if you want 'x-gcc-no-fixincludes' or whatever in there, just >>>> say :-) >>> >>> That would be great, but you could also add: >>> >>> /* this file depends on __gnuc_va_list being used for va_list */ >>> >>> and not bother changing fixincludes at all. :) But either of those two >>> comments added to the header would be preferable to looking for "BIONIC". >>> Thank you! >>> >>> With one of the two changes, the patch is approved. Thanks!
