From: Trevor Saunders <tsaund...@mozilla.com> Hi,
It turns out r212968 broke i686-elf because dispite appearances to the contrary ix86_return_in_memory () doesn't actually always use the fntype argument (sometimes the macro takes it and ignores it). So revert the relevent hunk from that commit. tested that x86_64-unknown-linux-gnu build is still fine, and i686-elf cross compiler builds with -werror, committed as obvious partial revert. Trev gcc/ * config/i386/i386.c (ix86_return_in_memory): replace one ATTRIBUTE_UNUSED where the attribute can actually sometimes be unused. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index db8643e..71660a1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-07-28 Trevor Saunders <tsaund...@mozilla.com> + + * config/i386/i386.c (ix86_return_in_memory): replace one + ATTRIBUTE_UNUSED where the attribute can actually sometimes be unused. + 2014-07-28 Marek Polacek <pola...@redhat.com> * doc/invoke.texi (-Wno-odr): Fix @item entry. Tweak wording. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 9de2035..1cb6297 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -8018,7 +8018,7 @@ ix86_libcall_value (enum machine_mode mode) /* Return true iff type is returned in memory. */ static bool -ix86_return_in_memory (const_tree type, const_tree fntype) +ix86_return_in_memory (const_tree type, const_tree fntype ATTRIBUTE_UNUSED) { #ifdef SUBTARGET_RETURN_IN_MEMORY return SUBTARGET_RETURN_IN_MEMORY (type, fntype); -- 2.0.1