Richard, I looked at my patch again. I already add -Wno-error to libgcov-util.o compilation: In line 200 of gcc/Makefile.in libgcov-util.o-warn = -Wno-error
In my test, I used gcc-4.6 as the host compiler. I got warning like this: In file included from ../../gcc/gcc/../libgcc/libgcov-util.c:30:0: ../../gcc/gcc/../libgcc/libgcov.h:184:30: warning: ISO C++ forbids zero-size array ‘ctrs’ [-pedantic] Can you check your buildlog to see if -Wno-error is added to the command line? Thanks, -Rong On Fri, Jul 11, 2014 at 9:47 AM, Rong Xu <x...@google.com> wrote: > I did see the warning in the bootstrap, but it did not exit the build. > I thought it was ok. > > I'll have a patch for this and send for review. > > -Rong > > On Fri, Jul 11, 2014 at 9:13 AM, Xinliang David Li <davi...@google.com> wrote: >> right. >> >> Rong, the fix would be just change ctr array size to 1. For each >> function, there should be at least one kind of counters -- see the >> assertion in build_fn_info_type. There are some code that do >> 'sizeof(gcov_fn_info)' when computing heap size -- they can be >> adjusted or leave it as it is (if not doing memcpy for the whole >> array). >> >> David >> >> On Fri, Jul 11, 2014 at 8:44 AM, Jakub Jelinek <ja...@redhat.com> wrote: >>> On Fri, Jul 11, 2014 at 08:42:27AM -0700, Xinliang David Li wrote: >>>> I wonder why. The struct definition for gcov_fn_info has not changed >>>> in this patch. >>> >>> Perhaps it has been used only in C until now? >>> >>> Jakub
