Hi Bruce,
> On 06/26/14 02:18, Rainer Orth wrote:
>> Ok for mainline?
>
> Could you please reformat the c_fix_arg's and test-text to be "here strings"
> a la:
>
> c_fix_arg = <<- _EOS_
> #undef signbit
> #define signbit(x) (sizeof(x) == sizeof(float) \
> \ ? __builtin_signbitf(x) \
> \ : sizeof(x) == sizeof(long double) \
> \ ? __builtin_signbitl(x) \
> \ : __builtin_signbit(x))";
> _EOS_;
>
> I changed the "here string" thingy to eat that tab-backslash
> and leave the rest of the tabs a few years ago.
It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my
original patch and the amended one and those backslashes after the
leading tab are still there.
> That is considerably more readable than:
>
> c_fix_arg = "#undef\tsignbit\n"
> "#define\tsignbit(x)\t(sizeof(x) == sizeof(float) \\\n"
> "\t\t\t ? __builtin_signbitf(x) \\\n"
> "\t\t\t : sizeof(x) == sizeof(long double) \\\n"
> "\t\t\t ? __builtin_signbitl(x) \\\n"
> "\t\t\t : __builtin_signbit(x))";
>
> and the other two are worse. Thank you!
Fully agreed, that's why I tried that route first.
I'm currently fighting to build autogen 5.18.3 and all its dependencies.
Trouble is, if we do require a version newer than 5.5.4 as documented in
install.texi, fixincludes make check will suddenly start to fail for
those whose autogen version isn't recent enough.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
