Hi Trev, 2014-06-27 1:55 GMT+02:00 <tsaund...@mozilla.com>: > From: Trevor Saunders <tsaund...@mozilla.com> > > Hi, > > While fixing up the hash_table patch's bustedness here I noticed the code > doesn't make any sense. What it inserts into the hash table will never match > what we try and look up in it. If you want to use hash_table or htab as a map > you need to deal with the keys yourself, it doesn't do it for you. > > varasm.c is the only caller of this target hook, and it correctly uses a > htab to check if the flags returned by the hook are the same as the > flags it has for the section, and emit an error if not. Therefore if we fixed > this machinary it would only ever emit redundant errors, so it would seem to > make sense to get rid of it.
Agreed. > I don't have a setup to test windows targets at hand, but I checked I can > buildd a compiler targeting x86_64-cygwin with this patch. Ok if someone can > really test it and it passes? I've tested your patch on mingw. So patch is Ok. Please apply. Thanks, Kai > Trev > > gccc/ > > * config/i386/winnt.c (i386_pe_section_type_flags): Remove > redundant diagnostic machinary.
