On 26 June 2014 05:03, Jeff Law <l...@redhat.com> wrote: > On 06/25/14 08:44, Richard Earnshaw wrote: >> >> On 23/06/14 07:58, Zhenqiang Chen wrote: >>> >>> Hi, >>> >>> Swapping operands in a ccmp will lead to illegal instructions. So the >>> patch disables it in simplify_while_replacing. >>> >>> The patch is separated from >>> https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. >>> >>> To make it clean. The patch adds two files: ccmp.{c,h} to hold all new >>> ccmp related functions. >>> >>> OK for trunk? >>> >>> Thanks! >>> -Zhenqiang >>> >>> ChangeLog: >>> 2014-06-23 Zhenqiang Chen <zhenqiang.c...@linaro.org> >>> >>> * Makefile.in: Add ccmp.o >>> * ccmp.c: New file. >> >> >> Do we really need a new file for one 10-line function? Seems like >> overkill. I think it would be better to just drop this function into >> recog.c. > > Right. And if we did want a new file, clearly the #includes need to be > trimmed :-)
Yes. It is not necessary for this patch itself. The file is in need for "[PATCH, 4/10] expand ccmp". Overall it will have more than 300 lines of codes. And #includes are trimmed. Previously all codes were in expr.c. It always conflicted when rebasing. So I move them in separate files. Thanks! -Zhenqiang
