> > On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: > >From: Trevor Saunders <tsaund...@mozilla.com> > > > >Hi, > > > >This patch adds a hash_map class so we can consolidate the boiler plate > >around > >using hash_table as a map, it also allows us to get rid of pointer_map which > >I > >do in this patch by converting its users to hash_map. > > Hello Trev, > I like your changes! One small question about pointer_set, which is unable > of deletion of items. Do you plan to migrate and simplify hash_map to be a > replacement for pointer_set?
Note that pointer-map use in LTO is quite performance critical. It would be good to double check that the new use of hash does not produce slower code. Honza
