On Mon, Jun 16, 2014 at 12:57 PM, Bernd Schmidt <ber...@codesourcery.com> wrote:
> This fixes an issue that showed up when regimplifying a call with a
> WITH_SIZE_EXPR for one of its arguments. At the moment we can end up trying
> to make a temporary and aborting because we don't know what size it ought to
> be.  The problem is that we call gimplify_expr with the wrong predicate:
> gimplify_arg uses is_gimple_lvalue in some cases instead of is_gimple_val,
> and regimplification needs to match that.
>
> Bootstrapped and tested on x86_64-linux, ok?

I think the same is true for assigns but they may go the two-arg
single-rhs re-gimplification.

IMHO the code is factored in a very bad way but your patch looks
correct to me.

Thus, ok.

Thanks,
Richard.

>
> Bernd

Reply via email to