> 1) instrument_mem_region_access/instrument_strlen should use a single
>    build_check_stmt call instead of two that they do now,

I agree with instrument_mem_region_access but the strlen case is quite different because checks are inserted at different sides of instrumented insn. Adding yet more flags and code paths to build_check_stmt would IMHO overcomplicate it.

-Y

Reply via email to