> > Well, I'm hesitant to add a new pass just to optimize a (irrelevant in > practice) > benchmark. I'm ok with strengthening existing infrastructure or enhancing > existing passes. > > The issue with these mini-passes is that they are very placement sensitive > and you don't easily get secondary effects. See the comment (and > "patch") about DCE - the ??? comment can be addressed the same > way Bernd addressed it (use cgraph_function_possibly_inlined_p). > Would that optimize the testcase? > > Note that the issue with nested function use prevails (not sure how to > solve that - same issue in Bernds patch).
I think this part of the patch can be made much cleaner by simply adding flag "used by one function only" to variables. We can compute it at the end of IPA queue and remove the code playing with local statics, nested functions and inlines. I can easily implement this analysis - perhaps it would be useful for AA or something else, too? Honza > > Thanks, > Richard. > > > -Sandra > >
