On Fri, May 16, 2014 at 4:00 AM, Richard Biener
<richard.guent...@gmail.com> wrote:
> On Fri, May 16, 2014 at 1:54 AM, Xinliang David Li <davi...@google.com> wrote:
>> Hi, debugging runtime bugs due to devirtualization can be hard for
>> very large C++ programs with complicated class hierarchy. This patch
>> adds the support to report this high level transformation via
>> -fopt-info (not hidden inside dump file) and the ability the do binary
>> search with cutoff.
>>
>> Ok for trunk after build and test?
>
> + else if (dump_enabled_p ())
> + {
> + location_t loc = gimple_location (ie->call_stmt);
> + dump_printf_loc (MSG_OPTIMIZED_LOCATIONS, loc,
> + "Discovered direct call to non-function in %s,
> "
>
> diagnostics start with lower-case. Why not merge this with the
> dump_file case? The point of all the infrastructure was to _not_
> need to distinguish the cases ...
>
Right -- however in this case I don't want the node 'order' to leak
into the opt report. Should we drop it?
> (similar for the other cases, and IIRC you miss one case in
> tree-ssa-pre.c calling ipa_intraprocedural_devirtualization?)
Good catch. Will add it.
thanks,
David
>
> Thanks,
> Richard.
>
>
>> thanks,
>>
>> David
