On 05/13/14 02:13, Marek Polacek wrote:
On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote:
On 13 May 2014 15:55, Marek Polacek <pola...@redhat.com> wrote:
On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote:
Thanks. Committed the patch @r210351 with changes:
(1) Create shrink-wrap.h.
(2) Move all shrink-wrapping related interfaces from function.h to
shrink-wrap.h.
(3) shrink-wrap.h is included in function.c, shrink-wrap.c and
config/i386/i386.c.
Could you please update the comment at the beginning of shrink-wrap.c?
It certainly shouldn't say the same what function.c says.
There are two /*..*/ blocks at the beginning.
As I understand the first /*...*/ is the copyright/license, which
should be same for all files.
And I had changed the second /*...*/ as
/* This file handles shrink-wrapping related optimizations. */
Which comment do you mean?
I meant the very first line that says "Expands front end tree to back
end RTL for GCC.". I guess best would be just to replace it with the
"This file handles shrink-wrapping related optimizations." line.
I think that's fixed in a follow-up patch from Zhenqiang.
jeff
