On 05/06/14 06:10, Ajit Kumar Agarwal wrote:
Hello All:
Could you please review this patch.
[PATCH] Break handler is used to support a normal hardware break.
This is similar to interrupt_handler except that RTBD should be used instead of
RTID.
Changelog
2014-05-06 Nagaraju <nmek...@xilinx.com>
* gcc/config/microblaze/microblaze-protos.h : Declaration of
microblaze_is_break_handler.
* gcc/config/microblaze/microblaze.c : Add functions to support break handler
* gcc/config/microblaze/microblaze.h : Add required defination declaration.
* gcc/config/microblaze/microblaze.md : Add pattern for generating instruction
rtbd.
Please follow conventions for ChangeLog. For example
* config/microblaze/microblaze.c (microblaze_break_function_p): New.
See http://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
Add documentation for _break_handler.
Add test case(s).
Code formatting issues:
+ a = lookup_attribute("break_handler",DECL_ATTRIBUTES (func));
Space before left paren, after comma.
+ else if (break_handler && strcmp (BREAK_HANDLER_NAME, fnname))
+ fputs ("_break_handler", file);
Incorrect indent.
+ if (microblaze_is_break_handler ())
+ return "rtbd\tr16, 0\;%#";
Ditto.
+ if (microblaze_is_break_handler ())
+ return "rtbd\tr16, 0\;%#";
Ditto.
Mailing list conventions do not permit restrictive annotations.
--
Michael Eager ea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
