> This looks fine. LIPO has similar change too. Other directions worth > looking into: > > 1) To model icache effect better, weighted callee size need to be > used with profile. The weight for BB may look like: min(1, > FREQ(BB)/FREQ(ENTRY)). > 2) When function splitting is turned on, are any inline heuristic > changes are needed? E.g. only consider the hot code part of node for > unit growth computation? > > We are also looking into more aggressive approach to track per loop > (inter-procedural) region growth limit, instead of using one single > global limit.
Per-loop growth seems interesting. I assume it is not hard to associate edges with loop nests and it has more of a local nature. Did you experiment with it? Honza
