On Thu, Apr 10, 2014 at 05:19:33PM +0000, Zamyatin, Igor wrote:
> @@ -282,8 +283,7 @@ fix_builtin_array_notation_fn (tree an_builtin_fn, tree 
> *new_var)
>  
>    for (ii = 0; ii < rank; ii++)
>      {
> -      an_loop_info[ii].var = build_decl (location, VAR_DECL, NULL_TREE,
> -                                 integer_type_node);
> +      an_loop_info[ii].var = create_tmp_var(integer_type_node, NULL);

Please fix up formatting (space before left paren), many times
in the patch.

Ok with those changes.

Looking at it, I'd question if integer_type_node is the right type for the
iterators, I'd say signed_size_type_node or something similar shouldn't be
used instead, otherwise I'm afraid if you have array notations for >= 2GB
arrays on 64-bit targets it might misbehave.
But that is definitely something for stage1, not 4.9 right now.

        Jakub

Reply via email to