On 04/04/14 17:38, Markus Trippelsdorf wrote:
I'm not sure that this is a good idea. This changes the existing behavior of -Wnon-virtual-dtor and causes hundreds of new warnings when building LLVM. Wouldn't it make more sense to move the 3rd ed Weffc++ behavior to the -Weffc++ flag alone?
IIUC you're using -Wnon-virtual-dtor on its own, is that right? What are the class shapes where you're seeing this behaviour?
AFAICT the -Wnon-virtual-dtor warning was an attempt to separate out that particular -Weffc++ warning, but it was broken.
nathan
