On 04/04/14 10:35, John David Anglin wrote:
On 4/4/2014 11:27 AM, Jeff Law wrote:
On 03/13/14 17:06, John David Anglin wrote:
This patch fixes PR rtl-optimization/60155.

The PA backend has a number of INSN patterns which trap on signed
overflow.  These are
implemented as parallels using the trap_if code.  Currently, single_set
does not consider
a parallel with a trap_if rtx to be a single set.  This causes an ICE in
gcse.c when an insn with
a trap_if is encountered.

The problem is fixed by implementing a gcse specific version of
"single_set" which only
looks at whether there is a single non-dead set in an insn pattern.  It
allows multiple other
sets if they are dead.

Tested on hppa-unknown-linux-gnu, hppa2.0w-hp-hpux11.11 and
hppa64-hp-hpux11.11.

OK for trunk?
Yes.  This is good.  Thanks.
Attached is an update to the previous change.  I was going to send it
this evening.

It adds an assert to check whether insn is actually an INSN and it
optimizes the
common case as in the single_set macro.

Tested on same targets as above.

Is update OK?  Otherwise, I will apply first version.
Yea, the update is fine.  THanks.

Sorry again for the delay.

jeff

Reply via email to