Changed the comment in log as the tests are not skipping for AVR only, but for 
all
The targets keeps_null_pointer_checks is true.
Corrected the log as per the comments. Please review it and commit it if it's 
OK.

Regards
Vishnu KS


2014-03-31  Vishnu K S  <vishnu....@atmel.com>

      * gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c: Skip test if 
keeps_null_pointer_checks
      is true for target. 
      * gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c: Ditto 
      * gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c: Ditto
      * gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c: Ditto
      * gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c: Ditto

--- a/gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c
@@ -1,6 +1,7 @@

/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-isolate-paths" } */
+/* { dg-skip-if "" keeps_null_pointer_checks } */


struct demangle_component
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c 
b/gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c
index bfcaa2b..912d98e 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fisolate-erroneous-paths-attribute 
-fdump-tree-isolate-paths -fdump-tree-phicprop1" } */
+/* { dg-skip-if "" keeps_null_pointer_checks } */


int z;
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c 
b/gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c
index 7dddd80..9c2c5d5 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-isolate-paths" } */
+/* { dg-skip-if "" keeps_null_pointer_checks } */


typedef long unsigned int size_t;
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c 
b/gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c
index c9c074d..d50a2b2 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fisolate-erroneous-paths-attribute 
-fdump-tree-isolate-paths -fdump-tree-phicprop1" } */
+/* { dg-skip-if "" keeps_null_pointer_checks } */


extern void foo(void *) __attribute__ ((__nonnull__ (1)));
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c 
b/gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c
index 4d01d5c..e6ae37a 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-isolate-paths -fdump-tree-optimized" } */
+/* { dg-skip-if "" keeps_null_pointer_checks } */



> -----Original Message-----
> From: Mike Stump [mailto:mikest...@comcast.net]
> Sent: Saturday, March 29, 2014 12:52 AM
> To: Mike & Elizabeth Stump; K_s, Vishnu
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: Skip gcc.dg/tree-ssa/isolate-*.c for AVR Target
> 
> On Mar 28, 2014, at 12:04 PM, Mike Stump <mikest...@comcast.net> wrote:
> >
> >> 2014-03-28  Vishnu K S <vishnu....@atmel.com >
> >>
> >> * gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c: Skip test for AVR
> >> * gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c: Ditto
> >> * gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c: Ditto
> >> * gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c: Ditto
> >> * gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c: Ditto
> 
> So, no gcc/testsuite/ in the log,, no space before >, and two spaces
> after the name before the <, and end sentences with a ..

> -----Original Message-----
> From: Mike Stump [mailto:mikest...@comcast.net]
> Sent: Saturday, March 29, 2014 12:52 AM
> To: Mike & Elizabeth Stump; K_s, Vishnu
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: Skip gcc.dg/tree-ssa/isolate-*.c for AVR Target
> 
> On Mar 28, 2014, at 12:04 PM, Mike Stump <mikest...@comcast.net> wrote:
> >
> >> 2014-03-28  Vishnu K S <vishnu....@atmel.com >
> >>
> >>    * gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c: Skip test for AVR
> >>    * gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c: Ditto
> >>    * gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c: Ditto
> >>    * gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c: Ditto
> >>    * gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c: Ditto
> 
> So, no gcc/testsuite/ in the log,, no space before >, and two spaces
> after the name before the <, and end sentences with a ..

Reply via email to