ok.
On Thu, Mar 27, 2014 at 9:02 AM, Dehao Chen <de...@google.com> wrote: > On Wed, Mar 26, 2014 at 4:05 PM, Xinliang David Li <davi...@google.com> wrote: >> is cgraph_init_gid_map called after linking? > > Oh, forgot that part. It's interesting that the test can pass without > another cgraph_init_gid_map call. > > Patch updated. Retested and the performance is OK. > > Dehao > >> >> David >> >> On Wed, Mar 26, 2014 at 3:54 PM, Dehao Chen <de...@google.com> wrote: >>> Patch updated, passed performance tests. >>> >>> Dehao >>> >>> On Tue, Mar 25, 2014 at 4:03 PM, Xinliang David Li <davi...@google.com> >>> wrote: >>>> Add comment to the new function. init_node_map is better invoked after >>>> the link step to avoid creating entries with for dead nodes. >>>> >>>> Ok if large perf testing is fine. >>>> >>>> David >>>> >>>> On Tue, Mar 25, 2014 at 3:38 PM, Dehao Chen <de...@google.com> wrote: >>>>> This patch refactors LIPO fixup related code to move it into a >>>>> standalone function. This makes sure that >>>>> symtab_remove_unreachable_nodes is called right after the fixup so >>>>> that there is not dangling cgraph nodes any time. >>>>> >>>>> Bootstrapped and regression test on-going. >>>>> >>>>> OK for google-4_8? >>>>> >>>>> Thanks, >>>>> Dehao
